<html>
<head><meta charset="utf-8"><title>stealable query · project-thir-unsafeck · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/index.html">project-thir-unsafeck</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html">stealable query</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="240088592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240088592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240088592">(May 24 2021 at 18:07)</a>:</h4>
<p>So <span class="user-mention" data-user-id="255061">@Léo Lanteri Thauvin</span> I r+'d the stealable query PR -- but was it a perf regression?</p>



<a name="240088601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240088601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240088601">(May 24 2021 at 18:07)</a>:</h4>
<p>I'm wondering if we should investigate that more</p>



<a name="240088605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240088605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240088605">(May 24 2021 at 18:07)</a>:</h4>
<p>That seems surprising</p>



<a name="240088617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240088617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240088617">(May 24 2021 at 18:07)</a>:</h4>
<p>I <em>would</em> though expect a memory use improvement</p>



<a name="240088812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240088812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240088812">(May 24 2021 at 18:09)</a>:</h4>
<p>It's a regression on instruction counts for <code>incr-full</code> and <code>incr-patched</code> runs</p>



<a name="240088875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240088875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240088875">(May 24 2021 at 18:09)</a>:</h4>
<p>So I guess it's just incremental compilation taking longer because it has an additional query to process, or something?</p>



<a name="240089062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240089062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240089062">(May 24 2021 at 18:11)</a>:</h4>
<p>As for the memory it does looks like an improvement, but it's pretty mixed</p>



<a name="240089216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240089216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240089216">(May 24 2021 at 18:12)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/278509-project-thir-unsafeck/topic/stealable.20query/near/240088601">said</a>:</p>
<blockquote>
<p>I'm wondering if we should investigate that more</p>
</blockquote>
<p>Happy to do that but I don't know much about incremental compilation, so I'd love to have some hints</p>



<a name="240090151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090151">(May 24 2021 at 18:19)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@Léo Lanteri Thauvin</span> I see, it's <em>specifically</em> incremental?</p>



<a name="240090171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090171">(May 24 2021 at 18:19)</a>:</h4>
<p>I wonder why that should be</p>



<a name="240090180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090180">(May 24 2021 at 18:19)</a>:</h4>
<p>At this point, are we building the THIR more than once for any given function?</p>



<a name="240090211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090211">(May 24 2021 at 18:20)</a>:</h4>
<p>Do you want to try to benchmark the <code>Box</code> variant I talked about?</p>



<a name="240090254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090254">(May 24 2021 at 18:20)</a>:</h4>
<p>It probably doesn't make much difference</p>



<a name="240090267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090267">(May 24 2021 at 18:20)</a>:</h4>
<p>Just N bytes per function</p>



<a name="240090545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090545">(May 24 2021 at 18:22)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/278509-project-thir-unsafeck/topic/stealable.20query/near/240090180">said</a>:</p>
<blockquote>
<p>At this point, are we building the THIR more than once for any given function?</p>
</blockquote>
<p>We're only building it once through the query for <code>mir_build</code> and building the patterns for exhaustiveness checking (not through the query)</p>



<a name="240090616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090616">(May 24 2021 at 18:22)</a>:</h4>
<p>THIR unsafeck is gated under <code>-Z thir-unsafeck</code> so it doesn't get ran in perf</p>



<a name="240090756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090756">(May 24 2021 at 18:24)</a>:</h4>
<p>got it</p>



<a name="240090821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cjgillot <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090821">(May 24 2021 at 18:24)</a>:</h4>
<p>If the regression happens for incr-full and incr-patch only, it may be related to stable hashing.</p>



<a name="240090924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090924">(May 24 2021 at 18:25)</a>:</h4>
<p><span class="user-mention" data-user-id="248906">@cjgillot</span> meaning that we have to do more hashing than we used to?</p>



<a name="240090955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cjgillot <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090955">(May 24 2021 at 18:25)</a>:</h4>
<p>We did not hash the THIR, and now we do.</p>



<a name="240090961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090961">(May 24 2021 at 18:25)</a>:</h4>
<p>right</p>



<a name="240090973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240090973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240090973">(May 24 2021 at 18:25)</a>:</h4>
<p>The query returns <code>(&amp;'tcx Steal&lt;thir::Thir&lt;'tcx&gt;&gt;, thir::ExprId)</code></p>



<a name="240091145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240091145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240091145">(May 24 2021 at 18:26)</a>:</h4>
<p>Right, makes sense</p>



<a name="240091228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240091228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240091228">(May 24 2021 at 18:27)</a>:</h4>
<p>For some reason I though "oh, the THIR gets stolen and dropped so it won't be hashed", but I'm assuming it gets hashed on its first call?</p>



<a name="240245610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240245610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240245610">(May 25 2021 at 20:27)</a>:</h4>
<p><span class="user-mention" data-user-id="248906">@cjgillot</span> What if we apply <code>no_hash</code> on <code>thir_body</code>?</p>



<a name="240245821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240245821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240245821">(May 25 2021 at 20:29)</a>:</h4>
<p>Would that make sense to (hopefully) negate the perf impact?</p>



<a name="240245991"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240245991" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240245991">(May 25 2021 at 20:30)</a>:</h4>
<p>And what is the consequence of making a query <code>no_hash</code>?</p>



<a name="240248959"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240248959" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cjgillot <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240248959">(May 25 2021 at 20:56)</a>:</h4>
<p>Making a query no_hash prevents the query system from knowing whether its results changed. As a consequence, the query system assumes that the no_hash query is green iff all its dependencies are green. In other words, everything happens as if all the information from all the dependencies appeared inside the <code>thir_body</code>. Hashing allows the query system to know that only a subset of this information appears in <code>thir_body</code>, and only rerun the query when that information subset changes.</p>



<a name="240385729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240385729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240385729">(May 26 2021 at 20:23)</a>:</h4>
<p>But it appears that this is ineffective for <code>thir_body</code>, since we get regressions on <code>incr-patched</code> runs, no?</p>



<a name="240388292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240388292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240388292">(May 26 2021 at 20:42)</a>:</h4>
<p>Opened a PR to test the perf impact of making it <code>no_hash</code></p>



<a name="240403216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240403216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240403216">(May 26 2021 at 23:09)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> <span class="user-mention" data-user-id="248906">@cjgillot</span> The results are in <a href="https://github.com/rust-lang/rust/pull/85729#issuecomment-849177378">https://github.com/rust-lang/rust/pull/85729#issuecomment-849177378</a></p>



<a name="240403317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240403317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240403317">(May 26 2021 at 23:10)</a>:</h4>
<p>It's a clear improvement on instruction counts</p>



<a name="240403428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240403428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240403428">(May 26 2021 at 23:12)</a>:</h4>
<p>But it looks kind of  mixed on max-rss and wall times</p>



<a name="240611320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240611320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240611320">(May 28 2021 at 14:26)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@Léo Lanteri Thauvin</span> hmm I r+'d, but I didn't look as closely as you did (embarassing)</p>



<a name="240611335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240611335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240611335">(May 28 2021 at 14:26)</a>:</h4>
<p>I wonder if we should change the perf output to show all three bits of info</p>



<a name="240611350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240611350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240611350">(May 28 2021 at 14:26)</a>:</h4>
<p>(cc <span class="user-mention" data-user-id="116122">@simulacrum</span>)</p>



<a name="240629079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240629079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240629079">(May 28 2021 at 16:35)</a>:</h4>
<p>wall times seem pretty noisy though</p>



<a name="240635304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/240635304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#240635304">(May 28 2021 at 17:23)</a>:</h4>
<p>I wonder if the report could, in general, always include a column reporting the changes in units of "the usual noise"...</p>



<a name="241145856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/241145856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#241145856">(Jun 02 2021 at 13:10)</a>:</h4>
<p>wall times are quite noisy, I usually ignore them</p>



<a name="241145869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/278509-project-thir-unsafeck/topic/stealable%20query/near/241145869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/278509-project-thir-unsafeck/topic/stealable.20query.html#241145869">(Jun 02 2021 at 13:10)</a>:</h4>
<p>I'd like to see max-rss though</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>